feat(sucrase): resolve .tsx files #448
Merged
+37
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellscape
approved these changes
Jun 10, 2020
shellscape
requested review from
Andarist,
btd,
bterlson,
danielgindi,
Rich-Harris,
TrySound and
wuweiweiwu
Andarist
reviewed
Jun 10, 2020
| const resolvedFilename = [`${resolved}.ts`, `${resolved}/index.ts`].find((filename) => | ||
| fs.existsSync(filename) | ||
| ); | ||
| const resolvedFilename = [ |
There was a problem hiding this comment.
if for .ts both ${resolved}.ts and ${resolved}/index.ts are checked then I believe that similar should be checked for .tsx, so both ${resolved}.tsx and ${resolved}/index.tsx
There was a problem hiding this comment.
@flipsasser please take a look at this comment
There was a problem hiding this comment.
Hey sorry somehow I missed this - will fix. Thanks for the review!
There was a problem hiding this comment.
It now follows the same pattern as ts imports
Andarist
approved these changes
Jun 24, 2020
|
@Andarist what is the NPM release schedule like, and can I assist in getting this update published? Please let me know if I can help. Thanks! |
LarsDenBakker
pushed a commit
to LarsDenBakker/plugins
that referenced
this pull request
Sep 12, 2020
* Resolve .tsx files * Load from index-level tsx files (just like TS) Co-authored-by: Flip Sasser <flip@inthebackforty.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
sucraseThis PR contains:
Are tests included?
Breaking Changes?
Description
The
@rollup/plugin-sucraseplugin does not resolve.tsxfiles. This PR patches that behavior to allow the use of@rollup/plugin-sucrasein React / TypeScript projects.It includes a test that imports a TSX file and snapshots the JSX output. It works. Which is great!
Here's a different way of saying it:
@rollup/plugin-sucrasewithtransforms: ["typescript", "jsx"]will correctly import both.tsand.tsxfiles.@rollup/plugin-sucrasecannot resolve.tsxfiles; only.ts.