fix(commonjs): idempotence issue #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to keep the diff small, but IMHO it'd make sense to refactor this promise map into a class: see thorn0@9a2a84b |
|
Thank you for taking the time to put the minimal PR together here. If you are open to more of a refactoring that could be worthwhile as well here while you are on it - if creating a class for this it might also be worth having that class designed to hold all other cached state to make for an easier clearing / management process as well. Does that seem like it would neaten things up or add more complexity? |
|
I'd rather have this merged as is now as it blocks the release of Prettier. |
|
@guybedford Thanks for the prompt release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
commonjsThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers: fixes #869
Description
State was erroneously shared between instances.