Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommonJS plugin doesn't recognize the __esModule field in module.exports = { __esModule: true, ... } #939

Closed
sodatea opened this issue Jul 15, 2021 · 1 comment
Closed

CommonJS plugin doesn't recognize the __esModule field in module.exports = { __esModule: true, ... } #939

sodatea opened this issue Jul 15, 2021 · 1 comment

Comments

@sodatea
Copy link
Contributor

sodatea commented Jul 15, 2021

Expected Behavior

Both imports from symbol and symbol2 return the .default field because they are both compiled from an ES module and contain the __esModule field.

Actual Behavior

The CommonJS plugin only recognizes the one with exports.__esModule. The one with module.exports = { __esModule: true, default: ... } is treated as a normal CJS module.

Additional Information

The module.exports = { __esModule: true, default: ... } pattern is found in babel-runtime v6 https://unpkg.com/browse/babel-runtime@6.26.0/core-js/symbol.js

It is used in some old codebases. So this issue causes incompatibility with them.

See also vitejs/vite#4090
@sodatea sodatea mentioned this issue Jul 15, 2021
Closed
6 tasks
githoniel added a commit to gem-mine/plugins that referenced this issue Jul 16, 2021
@githoniel
fix(commonjs): convert module.exports with __esModule property(roll…
e4fc1c5 
…up#939)
@githoniel githoniel mentioned this issue Jul 16, 2021
Merged
9 tasks
guybedford pushed a commit that referenced this issue Jul 24, 2021
@githoniel
fix(commonjs): convert module.exports with __esModule property(#939) (
7757aeb 
#942)

* fix(commonjs): convert module.exports with `__esModule` property(#939)

* test(commonjs): add test sample for cjs with esm-property

* feat(commonjs): defaultIsModuleExports support module.exports

* fix(commonjs): do not check right node in module.exports reassgin when defaultIsModuleExports = false(#935)
@pengx17 pengx17 mentioned this issue Jul 28, 2021
Merged
@guybedford
Copy link
Contributor

Fixed in #942.

@aleclarson aleclarson mentioned this issue Nov 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guybedford @sodatea