Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Resolve 13.0.2 Release Notes Description Lacking #953

Closed
3 of 4 tasks
aedryan opened this issue Jul 20, 2021 · 1 comment
Closed
3 of 4 tasks

Node Resolve 13.0.2 Release Notes Description Lacking #953

aedryan opened this issue Jul 20, 2021 · 1 comment

Comments

@aedryan
Copy link

aedryan commented Jul 20, 2021

  • Rollup Plugin Name: node-resolve
  • Rollup Plugin Version: 13.0.2

Documentation Is:

  • Missing
  • Needed
  • Confusing
  • Not Sure?

Please Explain in Detail...

13.0.2 claims to just be a "fix": https://github.com/rollup/plugins/blob/node-resolve-v13.0.2/packages/node-resolve/CHANGELOG.md#v1302

I believe this is the PR: #927

Your Proposal for Changes

The access package seems to be no longer used but is still included for some reason and is replaced with an asynchronous call to stat. I'm unsure of what issues existed with access except that it's permission focused where is stat is more general.

The bits that seem to fulfill the goal of the PR are here though and maybe unrelated to the stat/access swap: https://github.com/rollup/plugins/pull/927/files#diff-feca43bd4cf6b266d3fdd0ac000bac597028a1c87b78ea6f41fe5c5006d2c191R31-R123

This commit seems to best illustrate the intent of the PR: 0eed037

I would update the change log from "fix" to "fix: handle 'package.json' being in path"

@shellscape
Copy link
Collaborator

we're aware. PLEASE search issues first. look at the commit log for now.

@rollup rollup locked and limited conversation to collaborators Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants