fix(sucrase): Pass disableESTransforms option and make types match options we support
#984
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `disableESTransforms` option was added in [Sucrase 3.19.0]. The TypeScript types that ship with `@rollup/plugin-sucrase` says that `disableESTransforms` is a valid option, but supplying makes no difference. This passes the option on to Sucrase. [Sucrase 3.19.0]: https://github.com/alangpierce/sucrase/blob/c15268c2cd1ef4d613f41978478a8061c483aaae/CHANGELOG.md#3190-2021-06-23
|
@tjenkinson Friendly ping? (I saw you merged another PR a couple of days, I hope it’s ok to ping you! 😊 ) |
|
Looks good to me but I think it would be better if instead of the types for this package just omitting things from the sucrase types that we don’t support, it explicitly includes the types for the options we pass though like an allow list. Do you fancy having a go at that? If we had that already this wouldn’t be a bug, it would be a feature that adds the new type and passes though the option. |
Sorry, I don’t feel like I have time I can spend on that. |
|
No problem I just pushed a commit to do it |
tjenkinson
changed the title
disableESTransforms optiondisableESTransforms option and make types match options we support
|
Given I've pushed a change I probably shouldn't merge it. Pinging @shellscape |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Requirements:
npm run lintbefore creating a PR. (I believe the correct command ispnpm lint, it failed though before I made changes)/docswhere necessary (Couldn’t find a “/docs” folder.)Rollup Plugin Name:
sucraseThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers: none
Description
The
disableESTransformsoption was added in Sucrase 3.19.0.The TypeScript types that ship with
@rollup/plugin-sucrasesays thatdisableESTransformsis a valid option, but supplying it makes no difference.This passes the option on to Sucrase.