From 699b41c497de1c96570a0b449974161c2dcb87f6 Mon Sep 17 00:00:00 2001 From: yoho Date: Tue, 19 Apr 2022 23:05:24 +0800 Subject: [PATCH 1/2] fix: error types for dynamic-import-vars --- packages/dynamic-import-vars/types/index.d.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/dynamic-import-vars/types/index.d.ts b/packages/dynamic-import-vars/types/index.d.ts index 1196a109c..e3b2396c0 100644 --- a/packages/dynamic-import-vars/types/index.d.ts +++ b/packages/dynamic-import-vars/types/index.d.ts @@ -1,5 +1,4 @@ import { FilterPattern } from '@rollup/pluginutils'; -import { walk } from 'estree-walker'; import { Plugin } from 'rollup'; interface RollupDynamicImportVariablesOptions { @@ -25,7 +24,10 @@ interface RollupDynamicImportVariablesOptions { export class VariableDynamicImportError extends Error {} -export function dynamicImportToGlob(...params: Parameters): null | string; +export function dynamicImportToGlob( + node: import('estree').BaseNode, + sourceString: string +): null | string; /** * Support variables in dynamic imports in Rollup. From 2325020cce817f2744ef9254d09227b101325edd Mon Sep 17 00:00:00 2001 From: yoho Date: Tue, 19 Apr 2022 23:15:59 +0800 Subject: [PATCH 2/2] feat: test --- packages/dynamic-import-vars/test/types.ts | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/packages/dynamic-import-vars/test/types.ts b/packages/dynamic-import-vars/test/types.ts index 43c344937..2872477d2 100644 --- a/packages/dynamic-import-vars/test/types.ts +++ b/packages/dynamic-import-vars/test/types.ts @@ -1,6 +1,6 @@ import { RollupOptions } from 'rollup'; -import dynamicImportVars from '..'; +import dynamicImportVars, { dynamicImportToGlob } from '../src'; const config: RollupOptions = { input: 'main.js', @@ -13,7 +13,15 @@ const config: RollupOptions = { include: 'node_modules/**', exclude: ['node_modules/foo/**', 'node_modules/bar/**'], warnOnError: true - }) + }), + { + name: 'test:dynamicImportToGlob', + buildStart() { + const code = `import("./foo.js")`; + const node = this.parse(code); + dynamicImportToGlob(node, code); + } + } ] };