Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

3.0.1 and 3.0.2 have a regression on file size #130

Closed
Haroenv opened this issue Jan 11, 2018 · 4 comments · Fixed by #133, adambrgmn/extend-scripts#23 or verkholantsev/superoverload#36 · May be fixed by adambrgmn/frans-scripts#89
Closed

Comments

@Haroenv
Copy link

Haroenv commented Jan 11, 2018

see algolia/react-instantsearch#831 (comment) and size diff

Not sure if this is enough information?

cc @keithamus and @Rich-Harris

@keithamus
Copy link
Contributor

Fascinating. FWIW I ran this through our builds and the patch generated identical checksums with/without the patch, so I'm surprised to see this. Does your build generate sourcemaps? It might be useful to diff the sourcemap as it'll enumerate all of the files in the output.

@Haroenv
Copy link
Author

Haroenv commented Jan 12, 2018

I can see that buffer gets the node package instead of the browser one. algoliasearch gets the parse/node version, see my repro here: https://github.com/Haroenv/rollup-node-diff

@samouss
Copy link

samouss commented Jan 12, 2018

In the 3.0.0 the plugin is able to resolve the algoliasearch/lite but not with the 3.0.2. In the latter the plugin resolve the index.js instead of the lite.js version.

https://github.com/algolia/algoliasearch-client-javascript/blob/58a4b2dbe6258769a869e2668d0d66367359504c/package.json#L5-L10

@keithamus
Copy link
Contributor

Ah, so for algoliasearch the main key says index.js while the browser field has ./index.js. I will look into how to resolve that.

buffer could be because node-resolve sees this as a core module, and skips resolution logic. I'll look into this one too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.