Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Support resolve 1.11.1, add built-in test #223

Merged
merged 1 commit into from Jun 13, 2019

Conversation

bterlson
Copy link
Contributor

This PR fixes #222.

I wasn't sure why the test was disabled, possibly due to needing to pass in require. Happy to remove the test if it's not needed.

Confirmed tests and linters pass (and confirmed there were a number of test failures with resolve 1.11.1). Once exception: the symlink tests don't seem to run on Windows, but I doubt this change would impact them.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, looks good to me!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve 1.11.1 breaks importing "shadowed" core modules e.g. buffer
2 participants