From 056a017af7d9c81dc38f2f228cd13bbc6aa3b143 Mon Sep 17 00:00:00 2001 From: Anthony Fu Date: Fri, 21 Apr 2023 01:17:56 +0200 Subject: [PATCH] fix: typo --- src/ast/nodes/ImportExpression.ts | 8 +++++--- .../_expected.js | 10 ---------- 2 files changed, 5 insertions(+), 13 deletions(-) diff --git a/src/ast/nodes/ImportExpression.ts b/src/ast/nodes/ImportExpression.ts index fefe5461cf5..44423cdbefd 100644 --- a/src/ast/nodes/ImportExpression.ts +++ b/src/ast/nodes/ImportExpression.ts @@ -15,7 +15,7 @@ import type NamespaceVariable from '../variables/NamespaceVariable'; import type ArrowFunctionExpression from './ArrowFunctionExpression'; import type AwaitExpression from './AwaitExpression'; import type CallExpression from './CallExpression'; -import type FunctionDeclaration from './FunctionDeclaration'; +import type FunctionExpression from './FunctionExpression'; import type Identifier from './Identifier'; import type MemberExpression from './MemberExpression'; import type * as NodeType from './NodeType'; @@ -95,15 +95,17 @@ export default class ImportExpression extends NodeBase { const callExpression = memberExpression.parent as CallExpression; + console.log(callExpression); + if ( callExpression.arguments.length !== 1 || - !['ArrowFunctionExpression', 'FunctionDeclaration'].includes( + !['ArrowFunctionExpression', 'FunctionExpression'].includes( callExpression.arguments[0].type ) ) return; - const callback = callExpression.arguments[0] as ArrowFunctionExpression | FunctionDeclaration; + const callback = callExpression.arguments[0] as ArrowFunctionExpression | FunctionExpression; if (callback.params.length !== 1 || callback.params[0].type !== 'ObjectPattern') return; return getDeterministicObjectDestructure(callback.params[0] as ObjectPattern); diff --git a/test/form/samples/treeshake-deterministic-dynamic-import/_expected.js b/test/form/samples/treeshake-deterministic-dynamic-import/_expected.js index 985831ec002..ae725071d15 100644 --- a/test/form/samples/treeshake-deterministic-dynamic-import/_expected.js +++ b/test/form/samples/treeshake-deterministic-dynamic-import/_expected.js @@ -41,10 +41,6 @@ function bar3() { return 'bar3'; } -function baz3() { - return 'baz3'; // this should be tree-shaken -} - console.log('side-effect3'); function foo2() { @@ -59,19 +55,13 @@ function baz2() { return 'baz2'; } -function qux2() { - return 'qux2'; // this should be tree-shaken -} - var sub2 = /*#__PURE__*/Object.freeze({ __proto__: null, bar2: bar2, bar3: bar3, baz2: baz2, - baz3: baz3, foo2: foo2, foo3: foo3, - qux2: qux2, reexported: bar3 });