Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup watch has a fatal error on first run if encounters error #1773

Closed
mhkeller opened this issue Dec 2, 2017 · 6 comments · Fixed by #3081
Closed

Rollup watch has a fatal error on first run if encounters error #1773

mhkeller opened this issue Dec 2, 2017 · 6 comments · Fixed by #3081

Comments

@mhkeller
Copy link
Contributor

mhkeller commented Dec 2, 2017

Repro here: https://github.com/mhkeller/rollup-fatal-watch

If I introduce a syntax error on a file, rollup will give me a nice error and once I've fixed it, rebuild.

If I try to run rollup -w on a file that has that same syntax error, the watch exits. I have to fix the error and then run npm run build again.

It would be nicer if the behavior were the same between first run and during a build.

Perhaps related to #1563

@mhkeller mhkeller changed the title Rollup watch has a fatal error on first run Rollup watch has a fatal error on first run if encounters error Dec 2, 2017
@aubergene
Copy link

It looks like this is the same as #1442 which is marked as wontfix. I guess it would possible to have a list of files such as the config and input file(s) and to always watch them, and only add dependencies when a build is succesful. I had a quick brose of the code but couldn't work out where this might be added.

@mhkeller
Copy link
Contributor Author

mhkeller commented Dec 3, 2017

Good searching @aubergene. ya it seems that there is enough information gathered in the first run to try up to that point of failure. But there is certainly much I don't understand about what would make that possible or not ideal.

@shellscape
Copy link
Contributor

Hey folks. This is a saved-form message, but rest assured we mean every word. The Rollup team is attempting to clean up the Issues backlog in the hopes that the active and still-needed, still-relevant issues bubble up to the surface. With that, we're closing issues that have been open for an eon or two, and have gone stale like pirate hard-tack without activity.

We really appreciate the folks have taken the time to open and comment on this issue. Please don't confuse this closure with us not caring or dismissing your issue, feature request, discussion, or report. The issue will still be here, just in a closed state. If the issue pertains to a bug, please re-test for the bug on the latest version of Rollup and if present, please tag @shellscape and request a re-open, and we'll be happy to oblige.

@mhkeller
Copy link
Contributor Author

mhkeller commented Aug 8, 2019

Hi @shellscape. I think this issue would be great to fix. Please consider re-opening.

@shellscape
Copy link
Contributor

@mhkeller We're fast approaching the 2 year mark since it was last discussed, so I'm not sure there's a large demand here. Would you be willing to lead the effort? We're spread pretty thin so we would appreciate the help.

@mhkeller
Copy link
Contributor Author

@shellscape I made a PR for this including a test. If you can take a look, that would be great #3081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants