Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repeated re-emission of files emitted from a transform hook #2936

Merged
merged 1 commit into from Jun 13, 2019

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #2929

Description

Even though there was logic to re-emit assets emitted from a transform hook un incremental builds, this logic would only work once as the information about emitted assets was not passed on correctly. This PR fixes this + the same issue for chunks.

@lukastaegert lukastaegert merged commit 9d19a18 into master Jun 13, 2019
@lukastaegert lukastaegert deleted the gh-2929-fix-file-reemission branch June 13, 2019 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emitted chunk in plugin's transform hook lost after rebuild
1 participant