Skip to content

Explicitly allow null as return value for various hooks #2941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2019
Merged

Explicitly allow null as return value for various hooks #2941

merged 1 commit into from
Jun 14, 2019
+26 −22

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #2939

Description

Apparently, void is not the same as null | undefined. This PR changes the types to explicitly list null | undefined in various plugin hooks where it makes sense.

Sorry, something went wrong.

@lukastaegert lukastaegert mentioned this pull request Jun 14, 2019
Closed
@lukastaegert lukastaegert merged commit dd00ff5 into master Jun 14, 2019
@lukastaegert lukastaegert deleted the gh-2939-specify-null-hook-return-values branch June 14, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect typing for resolveId hook
1 participant
@lukastaegert