Only overwrite content when resolving import.meta properties #2986
+122
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
A small issue I stumbled across when working on #2938. As import meta properties are resolved AFTER everything else is rendered it is possible due to some quirks of magic-string that content is removed that should not be removed. For instance this code:
would become in SystemJS
Notice the missing closing bracket. This issue fixes this by making import.meta properties a "contentOnly" update, which should prevent other issues as well.