Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid generate .* thing #3034

Merged
merged 11 commits into from Aug 7, 2019
Merged

Avoid generate .* thing #3034

merged 11 commits into from Aug 7, 2019

Conversation

LongTengDao
Copy link
Contributor

@LongTengDao LongTengDao commented Aug 6, 2019

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers: #3023

Description

import * as x from 'x';
export { x as default };

Avoid source above generate below thing:

var x = require('x');
module.exports = x.*;

@LongTengDao LongTengDao changed the title Update getExportBlock.ts Avoid generate .* thing Aug 6, 2019
@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #3034 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3034   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files         165      165           
  Lines        5694     5694           
  Branches     1738     1738           
=======================================
  Hits         5048     5048           
  Misses        388      388           
  Partials      258      258
Impacted Files Coverage Δ
src/finalisers/shared/getExportBlock.ts 87.71% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdac4aa...39c4533. Read the comment docs.

@LongTengDao LongTengDao marked this pull request as ready for review August 6, 2019 04:32
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍

@LongTengDao
Copy link
Contributor Author

@lukastaegert With your help, I feel more and more familiar with rollup!

@lukastaegert lukastaegert merged commit 44a23bb into rollup:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants