New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for entryFileNames pattern used in combination with preserveModules option #3088
Add support for entryFileNames pattern used in combination with preserveModules option #3088
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3088 +/- ##
==========================================
+ Coverage 89.21% 89.22% +0.01%
==========================================
Files 165 165
Lines 5719 5725 +6
Branches 1737 1738 +1
==========================================
+ Hits 5102 5108 +6
Misses 380 380
Partials 237 237
Continue to review full report at Codecov.
|
…rveModules option
439591a
to
5d94815
Compare
Thanks for the PR! Just to let you know, I am a little busy with work-related things this week so a review may take until Friday. Thanks for your patience! |
No worries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good! As for your questions:
addons
are code snippets inserted via banner
/footer
/intro
/outro
. As for hashes in general, I agree that more changes would be necessary. I added a note to the documentation that this is not yet supported. If there is demand, this can always be added later, but at the moment I did not like the added complexity too much.
q: how |
The key difference is that when the |
With that in mind, one could argue that maybe people expect |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
fixes #2847
Description
The main use case for this is to support "renaming" of the TS files to JS while transpiling.
I've skipped support for:
[ext]
- let's wait to see if anybody really wants it before introducing this[hash]
- didn't have personal interest in implementing it and it wasn't straightforward for me how to implement this quickly, becausecomputeContentHashWithDependencies
expectsaddons
argument, those were not passed intogenerateIdPreserveModules
and I have no idea (without digging into this further) what those are