Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.21.0 includes a breaking change #3104

Closed
yesmeck opened this issue Sep 9, 2019 · 4 comments · Fixed by #3105
Closed

1.21.0 includes a breaking change #3104

yesmeck opened this issue Sep 9, 2019 · 4 comments · Fixed by #3105

Comments

@yesmeck
Copy link
Contributor

yesmeck commented Sep 9, 2019

  • Rollup Version: 1.21.0
  • Operating System (or Browser): Chrome
  • Node Version: 12

How Do We Reproduce?

#3080 introduced asset.type breaks all plugins which generate asset using asset.isAsset.

Expected Behavior

Minor version should backward compatibility。

Actual Behavior

It's breaks many plugins, like rollup-plugin-postcss

@lukastaegert
Copy link
Member

I see. Admittedly, these plugins were using an unofficial API, so technically it is only a breaking change in something we never promised to keep compatible; the proper way to emit assets is to use the file emission API, not mutate the bundle object.

I admit though that the file emission API only got powerful enough recently to support arbitrary asset emission, so I guess we will need to add a "fix" to keep supporting this pattern for the 1.x releases, especially considering that important plugins currently depend on it.

@lukastaegert
Copy link
Member

Fix at #3105

@slavafomin
Copy link

@lukastaegert thank you for fixing it so quickly. When should we expect the new release (1.21.1)?

@lukastaegert
Copy link
Member

Released now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants