interopNamespace added when interop is disabled

[gingur]

• Rollup Version: 1.27.9
• Operating System (or Browser): Windows 10
• Node Version: 10.15.3

How Do We Reproduce?

// rollup.config.js
config.output.format = 'cjs';
config.output.interop = false;

// entry
import('someExternal');

Expected Behavior

new Promise(function (resolve) { resolve(require('someExternal')); });

Actual Behavior

new Promise(function (resolve) { resolve(_interopNamespace(require('someExternal'))); });

[shellscape]

Thanks for opening an issue, and apologies that it took a while to get a response. Citing the issue template:

Issues without minimal reproductions will be closed! Please provide one by:

1. Using the REPL at https://rollupjs.org/repl/, or
2. Work to isolate the problem and provide the exact steps in this issue, or
3. Provide a minimal repository link (Read https://git.io/fNzHA for instructions).
   These may take more time to triage than the other options.

Please add a reproduction and we'll be happy to triage further.

[gingur]

@shellscape pretty sure I provided #2, I isolated the problem to a config flag, and provided the line of code. If you require #1 or #3 only, I would suggest removing #2 from your template.

[gingur]

Pretty sure the REPL doesn't use a file named rollup.config.js, but this is essentially the source https://tinyurl.com/wecehq3

[lukastaegert]

Yes, I think the interop flag was not considered when creating the interop logic for dynamic namespaces. Marking this as a bug as the suggested behaviour makes a lot of sense. I do not think it would be a big change so PR definitely welcome.

[gingur]

update:, still an issue in 2.2.0

[lukastaegert]

Fix at #3710