New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2.0.0] Remove active deprecations #3352
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release-2.0.0 #3352 +/- ##
=================================================
+ Coverage 93.53% 94.06% +0.53%
=================================================
Files 173 174 +1
Lines 6049 5969 -80
Branches 1795 1764 -31
=================================================
- Hits 5658 5615 -43
+ Misses 211 191 -20
+ Partials 180 163 -17
Continue to review full report at Codecov.
|
lukastaegert
force-pushed
the
remove-active-deprecations
branch
4 times, most recently
from
January 24, 2020 20:14
bc5c9a9
to
48c74c2
Compare
lukastaegert
force-pushed
the
remove-active-deprecations
branch
from
January 25, 2020 19:54
b8a0fea
to
5b14614
Compare
lukastaegert
changed the title
[WIP] [v2.0.0] Remove active deprecations
[v2.0.0] Remove active deprecations
Jan 25, 2020
lukastaegert
force-pushed
the
remove-active-deprecations
branch
from
January 25, 2020 20:00
5b14614
to
3d86d24
Compare
lukastaegert
force-pushed
the
release-2.0.0
branch
from
January 28, 2020 05:37
86f41ee
to
f4b9761
Compare
lukastaegert
force-pushed
the
remove-active-deprecations
branch
from
January 28, 2020 05:41
3d86d24
to
1e59438
Compare
lukastaegert
added a commit
that referenced
this pull request
Feb 4, 2020
* Remove active deprecations * Make inactive deprecations active * Improve coverage * Improve coverage * Refine transformer * Improve coverage * Refactoring option normalization * Improve coverage
lukastaegert
added a commit
that referenced
this pull request
Feb 8, 2020
* Remove active deprecations * Make inactive deprecations active * Improve coverage * Improve coverage * Refine transformer * Improve coverage * Refactoring option normalization * Improve coverage
lukastaegert
added a commit
that referenced
this pull request
Feb 14, 2020
* Remove active deprecations * Make inactive deprecations active * Improve coverage * Improve coverage * Refine transformer * Improve coverage * Refactoring option normalization * Improve coverage
lukastaegert
added a commit
that referenced
this pull request
Feb 14, 2020
* [v2.0.0] Update minimum required Node version to 10 (#3346) * Update CI to only run on Node 10 and 12, add engines to package.json * Update TypeScript target * Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests) * Remove minNodeVersion form tests * Reformat package.json * [v2.0.0] Bundle chokidar (#3331) * Create a separate chunk for watch mode via a dynamic import * Bundle chokidar * Handle conditional fsevents import * Only run tests on Node 10 and 12 as we want to do this anyway and chokidar depends on utils.promisify * Improve chunking * Refactor and simplify watcher * Make watcher a proper parameter * Only unwatch and watch on Linux systems * No longer run JS files through TypeScript for improved bundling performance * [v2.0.0] Remove active deprecations (#3352) * Remove active deprecations * Make inactive deprecations active * Improve coverage * Improve coverage * Refine transformer * Improve coverage * Refactoring option normalization * Improve coverage * Remove experimentalOptimizeChunks * Remove more unused code
lukastaegert
added a commit
that referenced
this pull request
Feb 19, 2020
* Remove active deprecations * Make inactive deprecations active * Improve coverage * Improve coverage * Refine transformer * Improve coverage * Refactoring option normalization * Improve coverage
lukastaegert
added a commit
that referenced
this pull request
Feb 19, 2020
* [v2.0.0] Update minimum required Node version to 10 (#3346) * Update CI to only run on Node 10 and 12, add engines to package.json * Update TypeScript target * Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests) * Remove minNodeVersion form tests * Reformat package.json * [v2.0.0] Bundle chokidar (#3331) * Create a separate chunk for watch mode via a dynamic import * Bundle chokidar * Handle conditional fsevents import * Only run tests on Node 10 and 12 as we want to do this anyway and chokidar depends on utils.promisify * Improve chunking * Refactor and simplify watcher * Make watcher a proper parameter * Only unwatch and watch on Linux systems * No longer run JS files through TypeScript for improved bundling performance * [v2.0.0] Remove active deprecations (#3352) * Remove active deprecations * Make inactive deprecations active * Improve coverage * Improve coverage * Refine transformer * Improve coverage * Refactoring option normalization * Improve coverage * Remove experimentalOptimizeChunks * Remove more unused code
lukastaegert
added a commit
that referenced
this pull request
Feb 26, 2020
* Remove active deprecations * Make inactive deprecations active * Improve coverage * Improve coverage * Refine transformer * Improve coverage * Refactoring option normalization * Improve coverage
lukastaegert
added a commit
that referenced
this pull request
Feb 26, 2020
* [v2.0.0] Update minimum required Node version to 10 (#3346) * Update CI to only run on Node 10 and 12, add engines to package.json * Update TypeScript target * Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests) * Remove minNodeVersion form tests * Reformat package.json * [v2.0.0] Bundle chokidar (#3331) * Create a separate chunk for watch mode via a dynamic import * Bundle chokidar * Handle conditional fsevents import * Only run tests on Node 10 and 12 as we want to do this anyway and chokidar depends on utils.promisify * Improve chunking * Refactor and simplify watcher * Make watcher a proper parameter * Only unwatch and watch on Linux systems * No longer run JS files through TypeScript for improved bundling performance * [v2.0.0] Remove active deprecations (#3352) * Remove active deprecations * Make inactive deprecations active * Improve coverage * Improve coverage * Refine transformer * Improve coverage * Refactoring option normalization * Improve coverage * Remove experimentalOptimizeChunks * Remove more unused code
lukastaegert
added a commit
that referenced
this pull request
Mar 6, 2020
* Remove active deprecations * Make inactive deprecations active * Improve coverage * Improve coverage * Refine transformer * Improve coverage * Refactoring option normalization * Improve coverage
lukastaegert
added a commit
that referenced
this pull request
Mar 6, 2020
* [v2.0.0] Update minimum required Node version to 10 (#3346) * Update CI to only run on Node 10 and 12, add engines to package.json * Update TypeScript target * Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests) * Remove minNodeVersion form tests * Reformat package.json * [v2.0.0] Bundle chokidar (#3331) * Create a separate chunk for watch mode via a dynamic import * Bundle chokidar * Handle conditional fsevents import * Only run tests on Node 10 and 12 as we want to do this anyway and chokidar depends on utils.promisify * Improve chunking * Refactor and simplify watcher * Make watcher a proper parameter * Only unwatch and watch on Linux systems * No longer run JS files through TypeScript for improved bundling performance * [v2.0.0] Remove active deprecations (#3352) * Remove active deprecations * Make inactive deprecations active * Improve coverage * Improve coverage * Refine transformer * Improve coverage * Refactoring option normalization * Improve coverage * Remove experimentalOptimizeChunks * Remove more unused code
lukastaegert
added a commit
that referenced
this pull request
Mar 6, 2020
* Remove active deprecations * Make inactive deprecations active * Improve coverage * Improve coverage * Refine transformer * Improve coverage * Refactoring option normalization * Improve coverage
lukastaegert
added a commit
that referenced
this pull request
Mar 6, 2020
* [v2.0.0] Update minimum required Node version to 10 (#3346) * Update CI to only run on Node 10 and 12, add engines to package.json * Update TypeScript target * Remove Bublé as a transpilation option from tests (it is still needed in sourcemap tests) * Remove minNodeVersion form tests * Reformat package.json * [v2.0.0] Bundle chokidar (#3331) * Create a separate chunk for watch mode via a dynamic import * Bundle chokidar * Handle conditional fsevents import * Only run tests on Node 10 and 12 as we want to do this anyway and chokidar depends on utils.promisify * Improve chunking * Refactor and simplify watcher * Make watcher a proper parameter * Only unwatch and watch on Linux systems * No longer run JS files through TypeScript for improved bundling performance * [v2.0.0] Remove active deprecations (#3352) * Remove active deprecations * Make inactive deprecations active * Improve coverage * Improve coverage * Refine transformer * Improve coverage * Refactoring option normalization * Improve coverage * Remove experimentalOptimizeChunks * Remove more unused code
This was referenced Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
generateBundle
insteadwriteBundle
insteadrenderChunk
insteadrenderChunk
insteadthis.watcher
on the plugin context.transform
hook can no longer returndependencies
.treeshake.pureExternalModules
option will now show a deprecation warning when used: usetreeshake.moduleSideEffects: 'no-external'
insteadimport.meta.ROLLUP_ASSET_URL_<..>
andimport.meta.ROLLUP_CHUNK_URL_<..>
in code will now show warnings: useimport.meta.ROLLUP_FILE_URL_<..>
insteadresolveAssetUrl
hook will now show a deprecation warning when used: useresolveFileUrl
insteadthis.emitAsset
: usethis.emitFile
this.emitChunk
: usethis.emitFile
this.getAssetFileName
: usethis.getFileName
this.getChunkFileName
: usethis.getFileName
this.isExternal
: usethis.resolve
this.resolveId
: usethis.resolve
generateBundle
will show a warning (removing properties is allowed, though): Usethis.emitFile
chunk.isAsset
on the bundle is deprecated: Usechunk.type === 'asset'
insteadThis PR will also make sure that unknown output options will trigger a warning when using the JavaScript API.