Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.0.0] Rename "esm" to "es" in docs and errors #3381

Merged
merged 1 commit into from Feb 14, 2020

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3370

Description

This changes documentation and error messages to refer to "es" format rather than "esm" format. It also adds "systemjs" as an alias for "system".

Breaking change: Output options (especially format) are no longer normalized before the outputOptions hook is run but after it is run to allow more freely formatted options that are then properly rewritten by plugins.

@lukastaegert lukastaegert changed the base branch from master to release-2.0.0 February 11, 2020 07:06
@lukastaegert lukastaegert added this to In progress in Release 2.0.0 via automation Feb 11, 2020
@lukastaegert lukastaegert moved this from In progress to Ready for merge in Release 2.0.0 Feb 11, 2020
@rollup-bot
Copy link
Collaborator

rollup-bot commented Feb 11, 2020

Thank you for your contribution! ❤️

You can try out this pull request locally via

npm install rollup/rollup#2.0.0-rename-esm-es

or load it into the REPL:
https://rollupjs.org/repl/?circleci=9367

@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #3381 into release-2.0.0 will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.0.0    #3381      +/-   ##
=================================================
- Coverage          94.23%   94.23%   -0.01%     
=================================================
  Files                173      173              
  Lines               5950     5947       -3     
  Branches            1757     1755       -2     
=================================================
- Hits                5607     5604       -3     
  Misses               190      190              
  Partials             153      153
Impacted Files Coverage Δ
src/finalisers/es.ts 100% <ø> (ø)
src/utils/parseOptions.ts 100% <100%> (ø) ⬆️
src/rollup/rollup.ts 100% <100%> (ø) ⬆️
src/finalisers/index.ts 100% <100%> (ø) ⬆️
src/Chunk.ts 95.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 467d666...eb59274. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 2.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

RFC [v2.0.0]: Align format specifiers passed to plugins with error messages and documentation
2 participants