Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.0.0] Bundle acorn, allow node ESM import fo Rollup, update dependencies #3391

Merged
merged 7 commits into from Feb 19, 2020

Conversation

lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Feb 18, 2020

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3385

Description

As apparently acorn plugins can now be configured to use the passed in acorn instance, this release will finally bundle acorn again, solving quite a few issues.

Not that this will break compatibility with acorn plugins that have not been updated to support this. See acornjs/acorn#870 (comment) for what needs to be done to make a plugin compatible.

Also this version of Rollup can now be experimentally imported in Node 13.8 as an ES module. This supports import {rollup} from 'rollup' via conditional exports. All Rollup artifacts can still be accessed via direct import from rollup/dist/....

However, the directory structure and file names for ES artifacts has been changed slightly as they are all places in an es subfolder now:

rollup
  ⎿rollup.js (CJS entry)
  ⎿rollup.d.ts
  ⎿rollup.browser.js (UMD browser build)
  ⎿shared/ (shared CJS files)
  ⎿dist
    ⎿ rollup (Node binary)
  ⎿ es (contains ESM builds)
    ⎿rollup.js (ESM entry)
    ⎿rollup.browser.js (ESM browser build)
    ⎿shared/ (shared ESM files)

Furthermore this updates dependencies and switches from the deprecated turbocolor to colorette.

@lukastaegert lukastaegert changed the base branch from master to release-2.0.0 February 18, 2020 07:55
@rollup-bot
Copy link
Collaborator

rollup-bot commented Feb 18, 2020

Thank you for your contribution! ❤️

You can try out this pull request locally via

npm install rollup/rollup#2.0.0-allow-node-esm-import

or load it into the REPL:
https://rollupjs.org/repl/?circleci=9425

@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #3391 into release-2.0.0 will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.0.0    #3391      +/-   ##
=================================================
- Coverage          94.23%   94.23%   -0.01%     
=================================================
  Files                173      172       -1     
  Lines               5949     5948       -1     
  Branches            1756     1756              
=================================================
- Hits                5606     5605       -1     
  Misses               190      190              
  Partials             153      153              
Impacted Files Coverage Δ
browser/crypto.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5c193d...1ec5f8e. Read the comment docs.

@lukastaegert lukastaegert added this to In progress in Release 2.0.0 via automation Feb 19, 2020
@lukastaegert lukastaegert moved this from In progress to Ready for merge in Release 2.0.0 Feb 19, 2020
@lukastaegert lukastaegert merged commit 3b84020 into release-2.0.0 Feb 19, 2020
Release 2.0.0 automation moved this from Ready for merge to Done Feb 19, 2020
@lukastaegert lukastaegert deleted the 2.0.0-allow-node-esm-import branch February 19, 2020 05:59
lukastaegert added a commit that referenced this pull request Feb 19, 2020
…encies (#3391)

* Support Node ESM

* Bundle acorn again, adjust directory structure and support Node ESM

* Update dependencies

* Collect licenses from all artifacts

* Switch to colorette instead of turbocolor

* Support Node ESM through conditional exports

* Fix test
@lukastaegert lukastaegert mentioned this pull request Feb 19, 2020
9 tasks
lukastaegert added a commit that referenced this pull request Feb 26, 2020
…encies (#3391)

* Support Node ESM

* Bundle acorn again, adjust directory structure and support Node ESM

* Update dependencies

* Collect licenses from all artifacts

* Switch to colorette instead of turbocolor

* Support Node ESM through conditional exports

* Fix test
lukastaegert added a commit that referenced this pull request Mar 6, 2020
…encies (#3391)

* Support Node ESM

* Bundle acorn again, adjust directory structure and support Node ESM

* Update dependencies

* Collect licenses from all artifacts

* Switch to colorette instead of turbocolor

* Support Node ESM through conditional exports

* Fix test
lukastaegert added a commit that referenced this pull request Mar 6, 2020
…encies (#3391)

* Support Node ESM

* Bundle acorn again, adjust directory structure and support Node ESM

* Update dependencies

* Collect licenses from all artifacts

* Switch to colorette instead of turbocolor

* Support Node ESM through conditional exports

* Fix test
ryuever added a commit to ryuever/rollup that referenced this pull request May 29, 2021
lukastaegert pushed a commit that referenced this pull request May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 2.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

Native ESM module support
2 participants