[v2.0.0] Remove @types dependencies #3395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release-2.0.0 #3395 +/- ##
=============================================
Coverage 95% 95%
=============================================
Files 171 171
Lines 5801 5801
Branches 1712 1712
=============================================
Hits 5511 5511
Misses 157 157
Partials 133 133
Continue to review full report at Codecov.
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via or load it into the REPL: |
lukastaegert
changed the title
lukastaegert
changed the title
lukastaegert
added a commit
that referenced
this pull request
Feb 26, 2020
* Replace Buffer with UInt8Array and get rid of Node types dependency * Git rid of ESTree dependency by using a specialized version of acorn's Node type * Fix test and adjust documentation
lukastaegert
added a commit
that referenced
this pull request
Mar 6, 2020
* Replace Buffer with UInt8Array and get rid of Node types dependency * Git rid of ESTree dependency by using a specialized version of acorn's Node type * Fix test and adjust documentation
lukastaegert
added a commit
that referenced
this pull request
Mar 6, 2020
* Replace Buffer with UInt8Array and get rid of Node types dependency * Git rid of ESTree dependency by using a specialized version of acorn's Node type * Fix test and adjust documentation
This was referenced Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #3108, #2142
Description
I hope this is the last change that is going into 2.0.0.
One problem that was reported repeatedly is that Rollup's dependency on
@types/nodewas causing issues for users that were not targeting Node but had conflicting types such as AMD or browser types. Moreover it was not clear why non-TypeScript-users would need to have external type dependencies.One suggestion was to make the types a peerDependency but in our opinion this would have caused unnecessary friction for TypeScript users. This PR finally fixes this by getting rid of the @types dependencies the following way:
Buffer. A NodeBufferhowever is a sub-class ofUInt8Array, which is a standard JS type and still very powerful. So this replacesBuffereverywhere withUInt8Array.ESTreetypes in our public interface, we only hadacorn.Nodeas a type internally. This PR replaces allESTree.Nodetypes with a simplified, copied version ofacorn.Nodethat reflects the properties present on all nodes. Note that you will need type casts if you need to access properties of specific node types.I also made sure that the typings test for the public interface that we have in place will ignore all
@typespackages that come from our dev dependencies and will thus ensure that we do not accidentally add a dependency on@types/nodeto the published artefact.