Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document next steps for each hook #3409

Closed
1 of 4 tasks
jakearchibald opened this issue Feb 28, 2020 · 1 comment · Fixed by #3418
Closed
1 of 4 tasks

Document next steps for each hook #3409

jakearchibald opened this issue Feb 28, 2020 · 1 comment · Fixed by #3418

Comments

@jakearchibald
Copy link
Contributor

Documentation Is:

  • Missing
  • Needed
  • Confusing
  • Not Sure?

Please Explain in Detail...

Forked from #3402.

https://rollupjs.org/guide/en/#hooks - It's currently difficult to figure out the order in which hooks are called, and how it relates to the rest of Rollup's processing.

This leads to confusion like #2739 - it isn't clear from the docs that renderChunk comes after hashing.

Your Proposal for Changes

State which hook comes first. Then for each hook, state what happens after that hook. As in, the docs for resolveId could end with something like:

Next lifecycle steps: This hook is called for all remaining imports in the currently processing module. Then load is called for each import in the same order.

(I don't know if the above is accurate, it's just an example)

Then, once that data is there, the community can help with creating a diagram.

@lukastaegert
Copy link
Member

I created a draft PR here: #3418. Build phase is done, I hope to complete the generate phase soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants