Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing type declaration for getCombinedSourcemap #3431

Merged
merged 3 commits into from Mar 10, 2020

Conversation

Anidetrix
Copy link
Contributor

@Anidetrix Anidetrix commented Mar 7, 2020

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #3431 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3431   +/-   ##
=======================================
  Coverage   95.00%   95.00%           
=======================================
  Files         171      171           
  Lines        5831     5831           
  Branches     1722     1722           
=======================================
  Hits         5540     5540           
  Misses        157      157           
  Partials      134      134           
Impacted Files Coverage Δ
src/utils/transform.ts 98.43% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d4a49f...315ed0c. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this. There was one issue with your implementation, namely that getCombinedSourcemap is only available in the transform hook but otherwise undefined. This was also spotted by our typings test (npm run test:typescript). I was able to fix this on your branch, so now it is good to be merged.

@lukastaegert lukastaegert merged commit ddc267e into rollup:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants