Avoid the assumption of Buffer in browser envs #3452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3452 +/- ##
==========================================
+ Coverage 95.01% 95.02% +<.01%
==========================================
Files 171 171
Lines 5843 5851 +8
Branches 1724 1726 +2
==========================================
+ Hits 5552 5560 +8
Misses 157 157
Partials 134 134
Continue to review full report at Codecov.
|
nitsky
reviewed
Mar 21, 2020
src/utils/FileEmitter.ts
Outdated
| @@ -24,6 +24,8 @@ interface OutputSpecificFileData { | |||
| bundle: OutputBundleWithPlaceholders; | |||
| } | |||
|
|
|||
| const isBrowser = typeof window !== 'undefined' && typeof document !== 'undefined'; | |||
There was a problem hiding this comment.
I see the motivation but I am not really happy about connecting the presence of Buffer with the presence of some completely unrelated browser globals. A simple fix would be to just check for the presence of Buffer, but there is no reason this cannot work in the browser. Except for equality and type checking, we are not using any more Buffer specific features. I will add some changes and a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was meant as a draft sorry!
This PR contains:
Are tests included?
Will try to include these asap (no clue yet how to mock this)
Breaking Changes?
List any relevant issue numbers:
#3450
Description
Since Buffers can't exist in the browser (node.js thing) we can safely make the condition of not checking for it in the browser.