Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): watch accepts single or array config #3453

Merged
merged 1 commit into from Mar 21, 2020

Conversation

lukeed
Copy link
Contributor

@lukeed lukeed commented Mar 21, 2020

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

The rollup.watch API accepts a single config object or an array of config objects. This is correct everywhere else (one, two, and three) except the shipped types.

@codecov
Copy link

codecov bot commented Mar 21, 2020

Codecov Report

Merging #3453 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3453   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files         171      171           
  Lines        5843     5843           
  Branches     1724     1724           
=======================================
  Hits         5552     5552           
  Misses        157      157           
  Partials      134      134           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8bc018...40cfbf0. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukastaegert lukastaegert merged commit 530e259 into rollup:master Mar 21, 2020
@lukeed lukeed deleted the patch-1 branch March 21, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants