Store locations for removed comments in cache #3476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via or load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #3476 +/- ##
=======================================
Coverage 95.84% 95.84%
=======================================
Files 174 174
Lines 5898 5902 +4
Branches 1736 1737 +1
=======================================
+ Hits 5653 5657 +4
Misses 126 126
Partials 119 119
Continue to review full report at Codecov.
|
lukastaegert
force-pushed
the
gh-3465-remove-inline-sourcemap-cache
branch
2 times, most recently
from
8d56d96
to
328ab86
Compare
lukastaegert
force-pushed
the
gh-3465-remove-inline-sourcemap-cache
branch
from
328ab86
to
8e841b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #3465
Description
Comments are not part of the cache, which had the effect that sourcemap comments were no longer removed when rebuilding using cached modules. This fixes this by adding the location of sourcemap comments to the cache (I decided against adding all comments to avoid blowing up the cache unnecessarily).