Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support node --disable-proto #3500

Closed
nitsky opened this issue Apr 16, 2020 · 1 comment
Closed

support node --disable-proto #3500

nitsky opened this issue Apr 16, 2020 · 1 comment

Comments

@nitsky
Copy link
Contributor

nitsky commented Apr 16, 2020

Hi, in rollup 2.4.0 acorn-private-class-elements was added as a transitive dependency: v2.3.5...v2.4.0. That package uses the __proto__ property, but node recently added a --disable-proto option to disable its use due to security issues: nodejs/node#32279. Similarly, deno also recently removed support for __proto__: denoland/deno#4341.

I opened an issue with acorn-private-class-elements: acornjs/acorn-private-class-elements#13. I am opening an issue here as well because I saw that rollup is currently using forks of a couple acorn packages from @guybedford. Do you suggest waiting for the change to be made in acorn-private-class-elements or adding another fork?

@shellscape
Copy link
Contributor

If you are sure this is a bug, please take the time to refile this issue using the issue template.

Hey there, thanks for opening an issue - Unfortunately you missed (or may have disregarded) the message about issue templates being required. Because our issue template was removed, we assume that this is a support request, and that's not something we offer here. Also, if you refile, please don't ignore Issue sections. They're in the template because they're useful to the maintainers of this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants