Improve side-effect tracking for call arguments #3539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tracked side-effects in nested calls
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via or load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #3539 +/- ##
=======================================
Coverage 96.24% 96.24%
=======================================
Files 176 176
Lines 6014 6023 +9
Branches 1773 1775 +2
=======================================
+ Hits 5788 5797 +9
Misses 112 112
Partials 114 114
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tracked side-effects in nested calls
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #3533
Description
See #3533. In this situation, the tracking logic that is meant to prevent infinite recursions in Rollup's side-effect detection would fire for the inner
.forEachcall expression because it thought this call had already been tracked as it was the same variable and path of the outer.forEachcall. Of course this is not the case, so for call expressions, the recursion prevention logic will now also discriminate based on original call expression and not only variable.