Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/3607 rollup watch only one config in exported array #3620

Merged
merged 11 commits into from Jun 8, 2020
Merged

Issue/3607 rollup watch only one config in exported array #3620

merged 11 commits into from Jun 8, 2020

Conversation

luwol03
Copy link
Contributor

@luwol03 luwol03 commented Jun 7, 2020

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no
  • coming soon

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3607

Description

This pull request allow us to exclude some configs from the watch mode with watch:false .

@codecov
Copy link

codecov bot commented Jun 7, 2020

Codecov Report

Merging #3620 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3620      +/-   ##
==========================================
+ Coverage   96.48%   96.54%   +0.05%     
==========================================
  Files         182      182              
  Lines        6236     6243       +7     
  Branches     1830     1832       +2     
==========================================
+ Hits         6017     6027      +10     
+ Misses        108      107       -1     
+ Partials      111      109       -2     
Impacted Files Coverage Δ
cli/run/watch-cli.ts 91.89% <100.00%> (+4.39%) ⬆️
src/utils/options/mergeOptions.ts 100.00% <100.00%> (ø)
src/watch/watch-proxy.ts 100.00% <100.00%> (ø)
src/watch/watch.ts 99.02% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37b876c...b1bccf4. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I have overstepped but I added the missing tests as I will go on vacation in two days and do not know how much time I will have then. If there are no concerns, I will release this tomorrow morning.

@luwol03
Copy link
Contributor Author

luwol03 commented Jun 7, 2020

Thank you for adding the tests, I had a hard time with it because I am not familiar with it.

And sometimes I think more complicated than it actually is. 😀

config.watch !== false && getObjectOption(config, overrides, name);

The way you changed it, is in my opinion, the best solution. I would be very happy if you can publish it tomorrow morning. Then I can finally work on my project for which I need that. 😀

Thank you very much for that.
I wish you a nice and relaxing vacation.

@lukastaegert lukastaegert merged commit 38fc513 into rollup:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollup watch only one config in exported array
2 participants