New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/3607 rollup watch only one config in exported array #3620
Issue/3607 rollup watch only one config in exported array #3620
Conversation
for excluding some configs from the watch mode
Codecov Report
@@ Coverage Diff @@
## master #3620 +/- ##
==========================================
+ Coverage 96.48% 96.54% +0.05%
==========================================
Files 182 182
Lines 6236 6243 +7
Branches 1830 1832 +2
==========================================
+ Hits 6017 6027 +10
+ Misses 108 107 -1
+ Partials 111 109 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if I have overstepped but I added the missing tests as I will go on vacation in two days and do not know how much time I will have then. If there are no concerns, I will release this tomorrow morning.
Thank you for adding the tests, I had a hard time with it because I am not familiar with it. And sometimes I think more complicated than it actually is. 😀 rollup/src/utils/options/mergeOptions.ts Line 165 in 6a0627e
The way you changed it, is in my opinion, the best solution. I would be very happy if you can publish it tomorrow morning. Then I can finally work on my project for which I need that. 😀 Thank you very much for that. |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #3607
Description
This pull request allow us to exclude some configs from the watch mode with
watch:false
.