Check for globalThis in UMD wrapper #3691
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
resolves #3666
resolves #3689
Description
This will add a check for
globalThis
to the UMD wrapper to find the global variable with higher priority thanthis
andself
. The latter are kept for compatibility with older environments of course. I briefly considered moving the check into the function argument where thethis
resides but decided against it to avoid performing this check in CJS and AMD environments. Thus you can still run the bundle in such an environment when none of the three global object options are available.Note that we need to scan for
globalThis
with atypeof
check to not throw on older environments.Before:
After: