Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle super in static class fields #3720

Merged
merged 2 commits into from Aug 13, 2020

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3702

Description

This updates all dependencies including the acorn plugins, which fixes the listed issue

@lukastaegert lukastaegert force-pushed the gh-3702-super-static-class-field-issue branch from b0069c7 to e85fc7a Compare August 13, 2020 19:24
@rollup-bot
Copy link
Collaborator

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-3702-super-static-class-field-issue

or load it into the REPL:
https://rollupjs.org/repl/?circleci=12499

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #3720 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3720   +/-   ##
=======================================
  Coverage   96.80%   96.80%           
=======================================
  Files         183      183           
  Lines        6320     6320           
  Branches     1843     1843           
=======================================
  Hits         6118     6118           
  Misses        105      105           
  Partials       97       97           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8333387...e85fc7a. Read the comment docs.

@lukastaegert lukastaegert merged commit 1cd3094 into master Aug 13, 2020
@lukastaegert lukastaegert deleted the gh-3702-super-static-class-field-issue branch August 13, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static class fields error: 'super' keyword outside a method.
2 participants