Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make options of PluginContext#parse optional #3750

Merged
merged 1 commit into from Aug 28, 2020

Conversation

intrnl
Copy link
Contributor

@intrnl intrnl commented Aug 28, 2020

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

I'm sure this is supposed to be optional.

@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #3750 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3750   +/-   ##
=======================================
  Coverage   96.99%   96.99%           
=======================================
  Files         184      184           
  Lines        6454     6454           
  Branches     1873     1873           
=======================================
  Hits         6260     6260           
  Misses        103      103           
  Partials       91       91           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bc7c90...f4a3e0f. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting, this was indeed a discrepancy with the internal types!

@lukastaegert lukastaegert merged commit ee3becc into rollup:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants