Fix SystemJS default variable conflict #3796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukastaegert
force-pushed
the
system-default-conflict
branch
from
8284bd3
to
4b7173f
Compare
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via or load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #3796 +/- ##
==========================================
- Coverage 97.03% 97.03% -0.01%
==========================================
Files 185 185
Lines 6478 6477 -1
Branches 1877 1876 -1
==========================================
- Hits 6286 6285 -1
Misses 101 101
Partials 91 91
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
resolves rollup/plugins#583
Description
In SystemJS at the moment, every default export is creating a new variable. This is causing issues when by accident the variable name conflicts with the name of an imported namespace, which is fixed here.