Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect async arrow thenable side effects #4120

Merged
merged 3 commits into from Jun 3, 2021

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #4116

Description

This will also detect side effects from accessing the then property or calling it when executing an async arrow function.

@lukastaegert lukastaegert changed the title Gh 4116 async arrow thenables Detect async arrow thenable side effects Jun 2, 2021
@lukastaegert lukastaegert changed the base branch from master to ignore-spread-element-effect June 2, 2021 05:49
@github-actions
Copy link

github-actions bot commented Jun 2, 2021

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-4116-async-arrow-thenables

or load it into the REPL:
https://rollupjs.org/repl/?pr=4120

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #4120 (09bb382) into master (5c05997) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4120   +/-   ##
=======================================
  Coverage   98.11%   98.12%           
=======================================
  Files         201      201           
  Lines        7068     7077    +9     
  Branches     2067     2071    +4     
=======================================
+ Hits         6935     6944    +9     
  Misses         64       64           
  Partials       69       69           
Impacted Files Coverage Δ
src/ast/nodes/ArrowFunctionExpression.ts 100.00% <100.00%> (ø)
src/ast/nodes/shared/FunctionNode.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c05997...09bb382. Read the comment docs.

@kzc
Copy link
Contributor

kzc commented Jun 2, 2021

lgtm

Base automatically changed from ignore-spread-element-effect to master June 3, 2021 04:41
@lukastaegert lukastaegert merged commit 63533b7 into master Jun 3, 2021
@lukastaegert lukastaegert deleted the gh-4116-async-arrow-thenables branch June 3, 2021 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

thenables not invoked from async arrow functions
2 participants