Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape dynamic import paths #4286

Merged
merged 2 commits into from Nov 30, 2021

Conversation

danielroe
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This PR addresses issues when using rollup for a project with ' in the path, for example /Users/Daniel's Projects/project/. Although normal imports are escaped correctly, it seems that dynamic imports are treated differently and we need to escape them as well.

Context: nuxt/nuxt#12909.

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #4286 (e8f849e) into master (0af78e3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    nuxt/framework#4286   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files         204      204           
  Lines        7319     7319           
  Branches     2084     2084           
=======================================
  Hits         7202     7202           
  Misses         58       58           
  Partials       59       59           
Impacted Files Coverage Δ
src/Chunk.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0af78e3...e8f849e. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great catch + fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants