Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: modify mkdirpath #4288

Merged
merged 2 commits into from Dec 9, 2021
Merged

refactor: modify mkdirpath #4288

merged 2 commits into from Dec 9, 2021

Conversation

mgrabowski84
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

resolves #4287

Description

Refactors mkdirpath to use fs.mkdirSync recursive option (if directory is nested all subsequent directories will be created, same as using mkdir -p in Bash).

@mgrabowski84 mgrabowski84 changed the title modify mkdirpath refactor: modify mkdirpath Nov 30, 2021
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #4288 (ab499f8) into master (dbcf24a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4288      +/-   ##
==========================================
+ Coverage   98.42%   98.45%   +0.02%     
==========================================
  Files         205      205              
  Lines        7317     7311       -6     
  Branches     2083     2082       -1     
==========================================
- Hits         7202     7198       -4     
+ Misses         57       55       -2     
  Partials       58       58              
Impacted Files Coverage Δ
src/utils/fs.ts 81.81% <100.00%> (+5.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbcf24a...ab499f8. Read the comment docs.

@lukastaegert lukastaegert merged commit 3834c87 into rollup:master Dec 9, 2021
@merceyz
Copy link

merceyz commented Dec 9, 2021

The recursive option was added in v10.12.0 but rollup supports >=10 so this is a breaking change

"node": ">=10.0.0"

https://nodejs.org/dist/latest-v16.x/docs/api/fs.html#fsmkdirsyncpath-options

@dnalborczyk
Copy link
Contributor

dnalborczyk commented Dec 10, 2021

The recursive option was added in v10.12.0 but rollup supports >=10 so this is a breaking change

"node": ">=10.0.0"

nodejs.org/dist/latest-v16.x/docs/api/fs.html#fsmkdirsyncpath-options

I think this should be permissible, given that node 10.x is end-of-life and unmaintained. rollup (and most other OSS projects in general) is only testing the latest LTS (minor/patch) versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RangeError: Maximum call stack size exceeded while building
4 participants