feat: add additional string prototype methods

[dnalborczyk]

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

List any relevant issue numbers:

Description

@lukastaegert could you look at match and matchAll if returnsBoolean is what is expected?

[codecov]

Codecov Report

Merging #4299 (20b154a) into master (a37e6ad) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4299   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files         205      205           
  Lines        7314     7314           
  Branches     2083     2083           
=======================================
  Hits         7201     7201           
  Misses         55       55           
  Partials       58       58           

Impacted Files	Coverage Δ
src/ast/values.ts	100.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a37e6ad...20b154a. Read the comment docs.

[lukastaegert]

No you are right, .match (and .matchAll) definitely do NOT return booleans. .match returns either an array with extra properties or null, and .matchAll returns an iterator. We should use returnsUnknown for both.
Similarly, .at can return undefined and should therefore also be a returnsUnknown. Checking the other ...at methods, .codePointAt should also be changed to unknown (charAt and charCodeAt seem to return consistent types, though).

Could you adjust those?
Otherwise, I am not sure it makes any sense to mark methods as deprecated, after all, nothing gets every removed from JavaScript so we need to keep supporting it. 😉

[dnalborczyk]

No you are right, .match (and .matchAll) definitely do NOT return booleans. .match returns either an array with extra properties or null, and .matchAll returns an iterator. We should use returnsUnknown for both.

ah, ok. I was about to ask. 😄

Similarly, .at can return undefined and should therefore also be a returnsUnknown. Checking the other ...at methods, .codePointAt should also be changed to unknown (charAt and charCodeAt seem to return consistent types, though). Could you adjust those?

I'll fix those as well.

Otherwise, I am not sure it makes any sense to mark methods as deprecated, after all, nothing gets every removed from JavaScript so we need to keep supporting it. 😉

the comments are more of a reminder. e.g. trimRight and trimLeft are only mentioned in the MDN as a side note, as being an alias for trimStart and trimEnd.

[dnalborczyk]

Otherwise, I am not sure it makes any sense to mark methods as deprecated, after all, nothing gets every removed from JavaScript so we need to keep supporting it. 😉

the comments are more of a reminder. e.g. trimRight and trimLeft are only mentioned in the MDN as a side note, as being an alias for trimStart and trimEnd.

in the same vein I'm gonna add those other deprecated "HTML" string methods (blink, link, small, etc.), which are still in V8 (incl. node.js) and possibly other engines.