Do not warn unnecessarily for namespace conflicts #4363
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Previously, the logic to resolve exports especially across conflicting namespace reexports was separate from the logic that would warn about conflicting namespace reexports.
In fact, the latter logic was broken in so far as it warned about situations like
There is no reason to warn here as explicit (re)exports always take precedence over namespace reexports.
This refactors the entire logic and merges both mechanisms. This has the advantage that you only get a warning when a conflicting export is actually used, which is in line with how it works in actual JS runtimes.