Ensure reexports are available for namespaces #4499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-4490-dynamic-imports-shared-exportsor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4499 +/- ##
=========================================
Coverage ? 98.74%
=========================================
Files ? 207
Lines ? 7357
Branches ? 2084
=========================================
Hits ? 7265
Misses ? 33
Partials ? 59
Continue to review full report at Codecov.
|
|
Thanks a lot @lukastaegert! amazing job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #4490
Description
This fixes an issue where namespaces in dynamic chunks were not referencing reexports correctly because imports were missing. See #4490 for the issue.
The problem was that the logic to make reexported variables available was run before facades were generated, and facade generation could add additional namespaces to the module.