fix: config path problem on windows #4501
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
resolves #3949
#4260
#4439
#4440
#4446
resolves #4465
Description
The
loadConfigFromBundledFile
function patches the defaultrequire
algorithm for thefileName
file. It replaces the require.extensions handler for it. In certain scenarios the file name parameter value in therequire.extensions
handler differs from the required file name (for example for symlinked files). The #3783 fix processed this by preparing the input file name before comparation. It uses the fsPromises.realpath function for it. The problem is that thefsPromises.realpath
result and the file name in therequire.extensions
handler are not the same in certain scenarios (refer to the relevant issue list above). I suggest use the require.resolve function instead of thefsPromises.realpath
because therequire
and therequire.resolve
functions use the same algorithm.