New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New rollup version results in different generated output and drops some if/else cases #4504
Comments
Interestingly, vanilla Rollup does not seem to remove anything here, guess I will need to dig deeper |
Yes same here. Thought I was too stupid 🤷♂️ Refactored code and had the issue from the other issue here. That's how I identified rollup as the cause. |
All of them look correct to me:
|
What about my use case? 🙈 |
I will need more time for the original issue. The repo will help, but I have some family things coming up. Therefore I reverted the main feature from 2.74.0 for now in a 2.74.1 release so that I can take some time to understand the issue properly. Hope 2.74.1 fixes your issue for now? But please keep this one open as I want to roll back the revert soon once I got things figured out. |
Hello again, |
@lukastaegert |
I can also confirm that 2.74.1 is ok. Thank you. |
I created a new PR #4510 that reimplements parameter tree-shaking in a more conservative way. Could you verify that this PR works for you via |
Hello and sorry for the delay, |
Rollup Version
2.74.0
Operating System (or Browser)
MacOS, Linux, Windows
Node Version (if applicable)
12.x.x
Link To Reproduction
https://github.com/digaus/rollup-demo
Expected Behaviour
Since 2.74.0 angular lib compilation now produces different and wrong results.
This is a major issue for us and might break other libs and applications because it is not noticed while compiling. It completely drops use cases...
This happens when bundling to
FESM2015
. InESM2015
code still looks fine...Adding
"rollup": "2.73.0"
to thepackage.json
fixes this for now...See https://github.com/digaus/rollup-demo for reproduction
Actual Behaviour
Do not drop any code :)
The text was updated successfully, but these errors were encountered: