Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructor default value was removed #4505

Closed
ericwangqing opened this issue May 19, 2022 · 3 comments · Fixed by #4510
Closed

Constructor default value was removed #4505

ericwangqing opened this issue May 19, 2022 · 3 comments · Fixed by #4510

Comments

@lukastaegert
Copy link
Member

Thank you so much! Considering the issues, I will roll back the parameter default tree-shaking in a patch release for now and refine it for another few days. Please keep the issue open as I intend to fix it with a proper release later.

@ericwangqing
Copy link
Author

Sounds great! looking forward the new release :)

@lukastaegert
Copy link
Member

I created a new PR #4510 that reimplements parameter tree-shaking in a more conservative way. Could you verify that this PR works for you via npm install rollup/rollup#parameter-defaults?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants