Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Cannot read property 'render' of null #4506

Closed
salmin89 opened this issue May 19, 2022 · 5 comments · Fixed by #4510
Closed

TypeError: Cannot read property 'render' of null #4506

salmin89 opened this issue May 19, 2022 · 5 comments · Fixed by #4510

Comments

@salmin89
Copy link

Rollup Version

2.74

Operating System (or Browser)

not relevant

Node Version (if applicable)

not relevant

Link To Reproduction

unsure how to replicate it in repl

Expected Behaviour

we use ng-packagr to build our Angular packages. Its dependencies just says latest rollup. Running a build with rollup@2.74 generates this error:

TypeError: Cannot read property 'render' of null

Downgrading rollup to @2.73 fixes this for now.

Actual Behaviour

latest version should still work

@lukastaegert
Copy link
Member

It would be really helpful to finally get a stack trace of this error. In any case, I will roll back the parameter default tree-shaking for now, which should hopefully fix the issue. If you could provide a reproduction of sorts for rollup@2.74.0, that would also be super helpful.

@salmin89
Copy link
Author

this is all I can provide since this is coming from a library that's using rollup and not our own code

image

@lukastaegert
Copy link
Member

Perfect, thanks a lot!

@lukastaegert
Copy link
Member

I created a new PR #4510 that reimplements parameter tree-shaking in a more conservative way. Could you verify that this PR works for you via npm install rollup/rollup#parameter-defaults?

@salmin89
Copy link
Author

I created a new PR #4510 that reimplements parameter tree-shaking in a more conservative way. Could you verify that this PR works for you via npm install rollup/rollup#parameter-defaults?

This works for us. Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants