Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure parameter defaults are deoptimized #4515

Merged
merged 1 commit into from May 29, 2022

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #4514

Description

Currently, we do not deoptimize parameter default values, which means we do not track deoptimizations or calls. This fixes it. See the linked issue for an example.

@github-actions
Copy link

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-4514_deopt-parameter-defaults

or load it into the REPL:
https://rollupjs.org/repl/?pr=4515

@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #4515 (d58815b) into master (03088cc) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #4515      +/-   ##
==========================================
- Coverage   98.78%   98.74%   -0.04%     
==========================================
  Files         208      208              
  Lines        7431     7437       +6     
  Branches     2120     2124       +4     
==========================================
+ Hits         7341     7344       +3     
  Misses         34       34              
- Partials       56       59       +3     
Impacted Files Coverage Δ
src/ast/nodes/ArrowFunctionExpression.ts 92.85% <0.00%> (-7.15%) ⬇️
src/ast/nodes/shared/FunctionNode.ts 96.55% <0.00%> (-3.45%) ⬇️
src/ast/nodes/shared/FunctionBase.ts 97.46% <75.00%> (-1.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03088cc...d58815b. Read the comment docs.

@lukastaegert lukastaegert merged commit dfea316 into master May 29, 2022
@lukastaegert lukastaegert deleted the gh-4514_deopt-parameter-defaults branch May 29, 2022 13:56
pos777 pushed a commit to pos777/rollup that referenced this pull request Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree-shaking of parameter defaults too aggressive
1 participant