New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll back parameter default tree shaking #4520
Conversation
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#roll-back-parameter-default-tree-shaking or load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4520 +/- ##
==========================================
- Coverage 98.77% 98.76% -0.01%
==========================================
Files 209 209
Lines 7436 7395 -41
Branches 2130 2108 -22
==========================================
- Hits 7345 7304 -41
Misses 32 32
Partials 59 59
Continue to review full report at Codecov.
|
* Add more regression tests * Remove call parameter deoptimization * Remove includeWithoutParameterDefaults * Remove default parameter tree-shaking logic * Clean up deoptimizations * Clean up deoptimizations
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
See comments at #4518
Description
Considering the unprecedented amount of small bugs that the parameter default tree-shaking has caused, I decided to roll back the feature indefinitely for now. The problem is that for this feature to work correctly, we need to be 100% sure that for every function, we can either track 100% of the calls or if not, deoptimize it. The latter has turned out to become the literal whack-a-mole, causing me to inject so much special logic into the feature that IMO is in no relation to its value. I kept all the regression tests (quite a few!) created for the feature in case I ever attempt it again after some major changes in the call tracking logic.
Sorry to everyone who was looking forward to this 😔