Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename Array.prototype.group/groupToMap #4531

Merged
merged 2 commits into from Jun 20, 2022

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented Jun 17, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

https://github.com/tc39/proposal-array-grouping#why-group-and-not-groupby

tc39/proposal-array-grouping#37

Description

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #4531 (5c29880) into master (1792cdf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4531   +/-   ##
=======================================
  Coverage   98.89%   98.89%           
=======================================
  Files         208      208           
  Lines        7332     7332           
  Branches     2094     2094           
=======================================
  Hits         7251     7251           
  Misses         26       26           
  Partials       55       55           
Impacted Files Coverage Δ
src/ast/nodes/shared/ArrayPrototype.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b55e50...5c29880. Read the comment docs.

@lukastaegert lukastaegert enabled auto-merge (squash) June 20, 2022 04:45
@lukastaegert lukastaegert merged commit 288bf77 into rollup:master Jun 20, 2022
@dnalborczyk dnalborczyk deleted the dn/array.prototype.group branch June 21, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants