Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: link in troubleshooting section is wrong #4691

Closed
2 of 4 tasks
shezhangzhang opened this issue Oct 26, 2022 · 1 comment · Fixed by #4763
Closed
2 of 4 tasks

[Docs]: link in troubleshooting section is wrong #4691

shezhangzhang opened this issue Oct 26, 2022 · 1 comment · Fixed by #4763

Comments

@shezhangzhang
Copy link

shezhangzhang commented Oct 26, 2022

Documentation is

  • Missing
  • Needed
  • Confusing
  • Not sure?

Please Explain in Detail...

image

As the screenshot above says, we need a namedExports option. But when I get in the link here, I can NOT find this option in @rollup/plugin-commonjs

Finally, I find namedExports option in this old repo: rollup-plugin-commonjs. But it has been moved to @rollup/plugin-commonjs

So, in my opinion, the documentation makes me feel a little bit confused.

Your Proposal for Changes

These are my suggestion:

  • Need docs to show how to deal this error with old rollup-plugin-commonjs (v23.0.2)
  • Need docs to show how to deal this error with new @rollup/plugin-commonjs (v10.1.0)
@rollup-bot
Copy link
Collaborator

This issue has been resolved via #4763 as part of rollup@3.8.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants