Prevent class ids from shadowing other variables #4697
Merged
+100
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-4696-class-name-shadowor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4697 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 215 215
Lines 7574 7593 +19
Branches 2098 2105 +7
=======================================
+ Hits 7500 7519 +19
Misses 24 24
Partials 50 50
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This PR has been released as part of rollup@3.2.5. You can test it via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
In #4674, we introduced a logic that would rewrite classes to have an id so that in case of name conflicts, they would retain the correct
class.name. Unfortunately, this could lead to shadowed variables because the name of this new id was not considered when deconflicting variable names. This is now fixed.