Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup sometimes fails with “Cannot read properties of null (reading 'included')” when using “external” #4722

Closed
tkalliom opened this issue Nov 24, 2022 · 2 comments · Fixed by #4725
Assignees

Comments

@tkalliom
Copy link

Rollup Version

3.4.0

Operating System (or Browser)

Linux

Node Version (if applicable)

16.18.1

Link To Reproduction

https://github.com/tkalliom/rollup-isincluded-bug

Expected Behaviour

Rollup does not do anything with dependencies declared as external.

Actual Behaviour

Rollup does some processing with an external dependency, failing with Cannot read properties of null (reading 'included'). This is a regression; we encountered this trying to upgrade Rollup from 2.6 to 3.4.

There was some previous discussion regarding this issue in the comments of #4297 – others have run into this as well

@lukastaegert
Copy link
Member

Thanks for the reproduction, it was very insightful. Fix at #4725 .

@rollup-bot
Copy link
Collaborator

This issue has been resolved via #4725 as part of rollup@3.5.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants