Fix isIncluded error when using rollup-plugin-typescript2 #4725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-4722-isincluded-failor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4725 +/- ##
=======================================
Coverage 99.03% 99.03%
=======================================
Files 216 216
Lines 7663 7664 +1
Branches 2116 2116
=======================================
+ Hits 7589 7590 +1
Misses 24 24
Partials 50 50
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This PR has been released as part of rollup@3.5.0. You can test it via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #4722
Description
While this bug only appeared when using rollup-plugin-typescript2, it was indeed a bug in Rollup. Basically what was happening was that
this.loadto pre-load a module, Rollup would not ensure the build was waiting for the load to complete (which would be fine), causing "incomplete" modules to appear when scanning for included modules in the generate phasethis.loadafter the build is completeThe fix is to skip incomplete modules in the relevant place.